Remove weird command procession limit

it was set to 1 too, wtf?!
minetest · Jan 17, 2024 · 9f684ea · 9f684ea
1 parent abf3142
commit 9f684ea
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 9 deletions.
diff --git a/src/network/connection.cpp b/src/network/connection.cpp
@@ -1158,16 +1158,13 @@ bool UDPPeer::processReliableSendCommand(
 
 void UDPPeer::RunCommandQueues(
 							unsigned int max_packet_size,
-							unsigned int maxcommands,
 							unsigned int maxtransfer)
 {
 
 	for (Channel &channel : channels) {
-		unsigned int commands_processed = 0;
 
 		if ((!channel.queued_commands.empty()) &&
-				(channel.queued_reliables.size() < maxtransfer) &&
-				(commands_processed < maxcommands)) {
+				(channel.queued_reliables.size() < maxtransfer)) {
 			try {
 				ConnectionCommandPtr c = channel.queued_commands.front();
 

diff --git a/src/network/connection.h b/src/network/connection.h
@@ -645,7 +645,6 @@ class UDPPeer : public Peer
 
 	void RunCommandQueues(
 					unsigned int max_packet_size,
-					unsigned int maxcommands,
 					unsigned int maxtransfer);
 
 	float getResendTimeout()

diff --git a/src/network/connectionthreads.cpp b/src/network/connectionthreads.cpp
@@ -248,9 +248,7 @@ void ConnectionSendThread::runTimeouts(float dtime)
 			rawSendAsPacket(udpPeer->id, 0, data, true);
 		}
 
-		udpPeer->RunCommandQueues(m_max_packet_size,
-			m_max_commands_per_iteration,
-			m_max_packets_requeued);
+		udpPeer->RunCommandQueues(m_max_packet_size, m_max_packets_requeued);
 	}
 
 	// Remove timed out peers

diff --git a/src/network/connectionthreads.h b/src/network/connectionthreads.h
@@ -102,7 +102,6 @@ class ConnectionSendThread : public Thread
 	Semaphore m_send_sleep_semaphore;
 
 	unsigned int m_iteration_packets_avaialble;
-	unsigned int m_max_commands_per_iteration = 1;
 	unsigned int m_max_data_packets_per_iteration;
 	unsigned int m_max_packets_requeued = 256;
 };