Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.6 changed object glow drastically #12686

Closed
LoneWolfHT opened this issue Aug 10, 2022 · 5 comments · Fixed by #12741
Closed

5.6 changed object glow drastically #12686

LoneWolfHT opened this issue Aug 10, 2022 · 5 comments · Fixed by #12741
Labels
Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does
Milestone
5.6.1

Comments

@LoneWolfHT
Copy link
Contributor

Minetest version
5.6
Summary

image

Steps to reproduce

Look at a glowing dropped item (like a MTG meselamp) with both 5.5.1 and 5.6, see the difference.
@LoneWolfHT LoneWolfHT added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Aug 10, 2022
@sfan5 sfan5 added the Regression Something that used to work no longer does label Aug 10, 2022
@GreenXenith
Copy link
Member

Can confirm; Colors on entity shown should be pure white and red (glow = -1, LIGHT_MAX, or 1000; v5.6)
image

@sfan5 sfan5 added Bug Issues that were confirmed to be a bug and removed Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels Aug 11, 2022
@sfan5 sfan5 added this to the 5.6.1 milestone Aug 11, 2022
@sfan5
Copy link
Member

sfan5 commented Aug 11, 2022

Relevant discussion: https://irc.minetest.net/minetest-dev/2022-08-10#i_6005846

@Skamiz
Copy link

Skamiz commented Aug 15, 2022

Also confirming. As far as I can tell an objects glow is basically being ignored completely.
image
Each side contains the same items. (Mese lamp and chalk for comparation) On the left sky light is blocked using glass from this mod: https://content.minetest.net/packages/StarNinjas/nextgen_tinted_glass/

@x2048
Copy link
Contributor

x2048 commented Sep 4, 2022

Should be fixed by 464043b, can you verify?

sfan5 added a commit to sfan5/minetest_classic that referenced this issue Sep 4, 2022
@sfan5
Fix glow values
29b6d6c 
this turned out to be an engine bug (minetest/minetest#12686)
@sfan5
Copy link
Member

sfan5 commented Sep 4, 2022

Verified.

@sfan5 sfan5 closed this as completed Sep 4, 2022
@x2048 x2048 mentioned this issue Sep 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues that were confirmed to be a bug Regression Something that used to work no longer does
Projects
None yet
Milestone
5.6.1
Development

Successfully merging a pull request may close this issue.

[No squash] Corrections to entity and node light calculation x2048/minetest
6 participants
@sfan5 @rubenwardy @x2048 @GreenXenith @LoneWolfHT @Skamiz