GUI: Automatic scaling of checkboxes and scrollbars #13666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly helpful on high-DPI screens or when 'gui_scaling' is changed
|
Note: just as the code sets a replacement sprite for the checkbox, There are some general improvements that could be made here (e.g. not stubbornly rendering sprites at a fixed size) but since the GUI is supposed to be replaced anyway we might opt to not bother. |
|
I'll happily test this as well, just need to wait on one of the win builds to update - never did have much luck building myself on windows. |
Wuzzy2
pushed a commit
to Wuzzy2/minetest
that referenced
this pull request
Jul 31, 2023
Mainly helpful on high-DPI screens or when 'gui_scaling' is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13665 by taking
gui_scalingand the display density into account for checkboxes, scrollbars and Irrlicht window buttons (currently used in file picker).I do not know why this code was limited to touchscreens but it does produce acceptable results on my 1080p screen with different GUI scaling factors.
To do
This PR is Ready for Review.
How to test
minetest --config <(echo gui_scaling=0.5)(thanks sfan5)gui_scaling = 2