Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom, tweakable with zoom_fov, default key: Z (like optifine) #1953

Closed
wants to merge 1 commit into from

Conversation

ShadowNinja
Copy link
Member

Rebased version of #583 by @EXio4.

Note: When zooming out you can see blocks loading that got unloaded because of culling when zooming.

@SmallJoker
Copy link
Member

The idea is good but mods should be able to define when a player can use zoom and when not.

@PilzAdam
Copy link
Contributor

👎 if there is no way for games or mods to control this.

@Calinou
Copy link
Member

Calinou commented Dec 13, 2014

Zoom should be doable both by the client and by mods.

Zooming is already possible using accessibility tools…

@kaeza
Copy link
Contributor

kaeza commented Dec 13, 2014

Related: #1075

@Wayward1
Copy link
Contributor

It seems this patch may not be compatible with the latest git

@ShadowNinja ShadowNinja added the Rebase needed The PR needs to be rebased by its author. label Dec 24, 2014
@paramat
Copy link
Contributor

paramat commented Dec 25, 2014

Should not be allowed by default and should be controllable by mods/games, for example only enabled if the player crafts binoculars or a telescope. I don't know about you but i don't have a zoom feature built in to my eyes 8)

@paramat
Copy link
Contributor

paramat commented Jan 2, 2015

My game window is only 1280x720, most devs don't care about or prioritise for smartphones =)

This must have a setting to enable/disable.

@Zeno-
Copy link
Contributor

Zeno- commented Jan 3, 2015

My game window is only 1280x720, most devs don't care about or prioritise for smartphones =)

Huh? This feature isn't for smartphones or small screens. It's for looking at far away objects (apply the patch and try it out). I imagine it would be pretty difficult/impossible to actually play while holding down the zoom key

@paramat
Copy link
Contributor

paramat commented Jan 4, 2015

I know, i was replying to the comment 'but you have a bigger screen'.

This pull must have enable/disable, otherwise it's a case of copying MC without thinking

@paramat
Copy link
Contributor

paramat commented Jan 7, 2015

Yes yet again =)
'Like optifine' / 'Because Minecraft' is not a good reason to merge, players are too used to the more stupid features of Minecraft and then expect these unquestioned in Minetest.
The selectable zoom FOV allows a server control over the amount of zoom, which is good and effectively allows a server to disable the feature.

A human being's vision does not magnify, increase resolution and reduce FOV when concentrating on a far away object. This feature is essentially adding player super-powers at no expense, similar to for examples, allowing players to dig nodes from far away, or allowing teleportation, or remote seeing of any part of the map.

I am addicted to watching Minecraft videos, although i do not own the game itself, and i see players casually using optifine to zoom-in and see things they wouldn't be able to otherwise, taking it for granted. They haven't earnt this super-power, or crafted a special item, it's just a cheaty feature a tasteless modder came up with without thinking how to integrate it properly into the game.

I think this feature would be great only if enabled by crafting a telescope or binoculars or a magical item, so enabled per-player and controlled from a mod. So it should be enabled when a player 'uses' an item, not controlled from a dedicated key, which should be left free for more keybinding options. This feature is too specialist and optional to permanently dedicate a new control key to.

👎

@SmallJoker
Copy link
Member

SmallJoker commented Jan 7, 2015

Then what's the use of this function when someone found this function and shares it with his friends? That's nonsense.

The idea is good, if the mods had control about this feature.

@C1ffisme
Copy link

I think that rather than making us have zoomable eyes, this should be usable with mods. Just so we can have more customization AND more realism.

@bendeutsch
Copy link
Contributor

I've been thinking about zoom lately, and so I stumbled upon this pull request.

My thoughts: this is 100% client side, in an open source game. Anyone can add this to their own client, and the server will never even know. It doesn't add any information that can't also be gotten by adding more hardware (i.e. bigger screen resolution), or by simply changing your FOV using the GUI built for that very purpose.

Yes, it would be nice if mods could affect this, allowing / triggering it when using a telescope. It could also benefit from a smooth transition, slowing down mouse look, adjusting the client view distance and adding a circular black vignette effect. But most of this is not relevant to this patch.

If you want a difference between client-only and server-supported zoom, consider this suggestion: the server controls what block updates the client receives. If the client wants to take a closer look at the blocks it already has, go ahead. But if it wants to see further, then it can only do so with help from the server. And that's where mods could come in.

@rubenwardy
Copy link
Member

It's currently impossible to make a snipper rifle scope. I'd definitely like to see a zoom mod api.

Players can currently modify their client to give themselves fly, that doesn't mean we should give them fly by default

@DonBatman
Copy link
Contributor

I would love to see a zoom api. Binoculars, scopes and more could happen. I am sure modders would come up with a lot more ideas.

@bendeutsch
Copy link
Contributor

Well, game design is as much about what to leave out as what to put in. So it should probably be up to the game to determine whether such unaided zoom (as in this pull request, a mod api is another thing) is available. Or even how much it is available. Or how much it is available per player. I can imagine server admins would appreciate such a tool, regardless of the normal player experience.

I'd suggest a set_player_unaided_min_fov(player, fov) function, to set the FOV that can be reached by pressing the zoom button discussed here. How does that sound?

(As for the comparison with flying: flying without permission can get noted by the server and various anticheat mods. Zooming could not.)

@ghost
Copy link

ghost commented Jul 31, 2016

It's a game, a first person game, let us have +zoom!

@bendeutsch
Copy link
Contributor

I forked this and rebased to current master (as of Aug 1st 2016): https://github.com/bendeutsch/minetest/tree/zoom

I'll see if I can add an API for mods as outlined above. This would only affect the zoom key, though, not the manual FOV settings.

@paramat
Copy link
Contributor

paramat commented Aug 1, 2016

I feel this must be controlled and granted by server or mod though, no unaided or granted-by-default zoom. So in survival one must build a telescope or attain a magickal power.

@rubenwardy
Copy link
Member

This is a gameplay thing, so subgames and mods should be able to choose to enable this per player, or whether to make a item make the view zoom when selected. You could then enable it only if a player has eye bionics in their inv, or binoculars in their selected item slot

@bendeutsch
Copy link
Contributor

I propose a new default-off privilege "zoom" as a simple gating mechanism. Code in pull request #4400 . Comments welcome.

@paramat
Copy link
Contributor

paramat commented Aug 2, 2016

#4400 is much more preferable, so closing this.

@paramat paramat closed this Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Low priority Rebase needed The PR needs to be rebased by its author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet