add a plantlike_leaves setting

[HybridDog]

https://github.com/minetest/minetest/pull/2594/files?w=1

[est31]

Why that value, and not 1?

[HybridDog]

1 means that the height and the width of the polygon is the node height (1m).
lf the polygon's width is 1, there would be visual spaces between the nodes because the polygon is diagonal seen from above, and so the the visual space size would be 1-sqrt(1*1/2), which is ~0.2929

[est31]

ok then.

[est31]

see comment, otherwise 👍

[est31]

I'm not sure, is it possible here to be f->waving == 1?

[HybridDog]

No, l disabled it here because l think waving leaves with black look strange and you usually disable fancy leaves if you want to decrease lag.
l can enable it again if you want it.

[est31]

If you document the change, you can leave it in.

[HybridDog]

Where shall l document it?

[paramat]

I feel this is too specialised, should be done by mod instead, it's easy to override a default node definition.

[HybridDog]

But if it's a mod the players can't decide themselves if they want plantlike leaves.

[C1ffisme]

I too feel like this should be done by mod. Perhaps a setting in minetest.conf or in the settings menu could be used by mod-makers. Then you can use minetest.overwrite_node():

if minetest.getsettingbool(plantlike_leaves) then
    minetest.overwrite_node({
        drawtype="plantlike",
    })
end

[HybridDog]

it's already done by mods, but if you want to have plantlike leaves on every server it doesn't work

[C1ffisme]

Oh yes, I suppose that's true. If this is done then the work is done server side.
Still, it seems wrong that this kind of thing overwrites drawtypes.

[kilbith]

This PR does still matter now we have simple leaves ?