Add slippery #817

Zeg9 · 2013-07-09T11:21:38Z

Title says about it.

PilzAdam · 2013-07-09T11:53:43Z

builtin/item_entity.lua

@@ -86,7 +86,7 @@ minetest.register_entity("__builtin:item", {
 		local nn = minetest.get_node(p).name
 		-- If node is not registered or node is walkably solid and resting on nodebox
 		local v = self.object:getvelocity()
-		if not minetest.registered_nodes[nn] or minetest.registered_nodes[nn].walkable and v.y == 0 then
+		if not minetest.registered_nodes[nn] or (minetest.registered_nodes[nn].walkable and not minetest.registered_nodes[nn].groups.slippery) and v.y == 0 then


You shoud use minetest.get_item_group() here.

Zeg9 · 2013-07-09T12:47:34Z

@PilzAdam: all fixed

PilzAdam · 2013-07-11T01:03:23Z

The wielditem walk animation, view bobbing and footstep sounds are still played why sliding over ice.

Calinou · 2013-07-13T09:34:49Z

The wielditem walk animation, view bobbing and footstep sounds are still played why sliding over ice.

And? Try to slide on ice in real life and you'll see...

bas080 · 2013-07-18T16:52:56Z

Can't wait what kind of gameplay this would add to the game, Slippery icy mountains or just a big slippery lake @Calinou lol.

RealBadAngel · 2013-07-23T23:32:13Z

it could be fun and usable

proller · 2013-07-24T10:15:19Z

+1
and maybe make slippery dirt with water_flowing on top

BlockMen · 2013-07-31T14:25:44Z

+1
Very nice

minetest/minetest#817

Wuzzy2 · 2014-08-13T19:20:44Z

What’s preventing this from being merged? The mistakes have been dealth with, the rebase has obviously been done, too (1 commit now).

EvergreenTheTree · 2014-08-13T22:37:11Z

@Wuzzy2 I agree.

nerzhul · 2015-02-16T14:45:55Z

Hi, please fix the following things if you want a merge:

Coding style
Rebase
Handle the error, don't use a try .. catch

Zeno- · 2015-03-01T13:44:47Z

It would take longer to rebase this than write it from scratch. Best closed IMO

kilbith · 2015-12-03T21:11:40Z

No valid reason to trash it while most people were enthusiastic.
Please someone re-open that for rebasing and/or not sinking this into oblivion.

@est31 @paramat

est31 · 2015-12-04T10:31:46Z

What @Zeno- said is probably right, but I guess its not that large of a PR, therefore its ok to be open as well. Reopening on special request of @kilbith .

C1ffisme · 2015-12-04T15:06:25Z

Wouldn't it kill two birds with one stone just to make ObjectRef slip, and if an entity does not need to slip, change a variable like object.slip?

est31 · 2015-12-05T12:55:49Z

@C1ffisme that's something separate, and not as simple as you describe it. And, the effect this PR wants to obtain would not be possible to achieve in a lag-free manner.

sapier · 2015-12-18T20:11:03Z

What's use of keeping this one alive if there's obviously noone interested in the feature?

kilbith · 2015-12-18T20:14:15Z

What's use of keeping this one alive if there's obviously noone interested in the feature?

At least 2 core-devs are expressly interested.

ghost · 2015-12-29T18:48:26Z

I've updated this to master and to allow slipping off nodes, with a physics override for mods to utilise per player (e.g. grippy boots):

master...cmdskp:master

And test values to try for minetest-game:
minetest/minetest_game@master...cmdskp:master

Just need help with how to check the protocol version in "content_cao.cpp", before I can offer it in a pull.

ObaniGemini · 2016-02-20T21:51:07Z

What's up with it ?

paramat · 2016-05-22T08:32:13Z

@Zeg9 very old PR, any comments?
ghost is now a deleted user.
Does anyone want to open a new PR with Zeg9's code rebased? @Ekdohibs ?

paramat · 2016-05-23T04:10:09Z

At least 2 core-devs are expressly interested.

BlockMen has left, est31 isn't necessarily supporting the feature.
Zeg9 has been inactive on Github for a year.
I think this can be closed soon.

@Ekdohibs or anyone interested please could you copy the code for yourselves so we can close this?

Wuzzy2 · 2016-05-23T11:38:45Z

Is it really neccessary to rebase a PR which only has one commit? ;-)

paramat · 2016-06-02T07:03:15Z

Time to close this.
@Ekdohibs just notifying you in case you want to copy this code for your own use in a new PR.

paramat · 2017-08-13T20:48:54Z

#6237 merged.

PilzAdam reviewed Jul 9, 2013
View reviewed changes

Add slippery

3a74810

proller pushed a commit to freeminer/freeminer that referenced this pull request Nov 27, 2013

Merge remote-tracking branch 'Zeg9/slippery'

6dc68e7

minetest/minetest#817

sapier added the Feature Request label Jun 20, 2014

sfan5 added rebase needed and removed feature request labels Jul 6, 2014

sapier force-pushed the master branch 2 times, most recently from c7b9cf1 to c24e075 Compare August 19, 2014 20:23

ShadowNinja force-pushed the master branch 4 times, most recently from 73b8c08 to 56195dc Compare September 22, 2014 01:02

ShadowNinja force-pushed the master branch from cba038e to b98e8d6 Compare October 7, 2014 20:53

Zeno- force-pushed the master branch from 2642ca4 to a1db83e Compare November 25, 2014 02:39

kwolekr force-pushed the master branch from decd9c5 to 3f83ca2 Compare December 25, 2014 03:28

Zeno- closed this Mar 1, 2015

est31 reopened this Dec 4, 2015

paramat added the Possible close label May 22, 2016

paramat mentioned this pull request May 23, 2016

Add multiple levels of slippery-ness #4158

Closed

paramat closed this Jun 2, 2016

paramat added @ Server / Client / Env. and removed @ Script API Enhancement Possible close labels Jun 2, 2016

Wuzzy2 mentioned this pull request Jun 2, 2016

Add slippery group for nodes (players/items slide) #4182

Closed

Wuzzy2 mentioned this pull request Aug 11, 2017

Add slippery group for nodes (players/items slide) (take 3) #6237

Closed

Desour mentioned this pull request Oct 14, 2018

Nodes that make you walk slower/faster #7785

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add slippery #817

Add slippery #817

Zeg9 commented Jul 9, 2013

PilzAdam Jul 9, 2013

Zeg9 commented Jul 9, 2013

PilzAdam commented Jul 11, 2013

Calinou commented Jul 13, 2013

bas080 commented Jul 18, 2013

RealBadAngel commented Jul 23, 2013

proller commented Jul 24, 2013

BlockMen commented Jul 31, 2013

Wuzzy2 commented Aug 13, 2014

EvergreenTheTree commented Aug 13, 2014

nerzhul commented Feb 16, 2015

Zeno- commented Mar 1, 2015

kilbith commented Dec 3, 2015

est31 commented Dec 4, 2015

C1ffisme commented Dec 4, 2015

est31 commented Dec 5, 2015

sapier commented Dec 18, 2015

kilbith commented Dec 18, 2015

ghost commented Dec 29, 2015

ObaniGemini commented Feb 20, 2016

paramat commented May 22, 2016 •

edited

Loading

paramat commented May 23, 2016 •

edited

Loading

Wuzzy2 commented May 23, 2016

paramat commented Jun 2, 2016

paramat commented Aug 13, 2017

Add slippery #817

Add slippery #817

Conversation

Zeg9 commented Jul 9, 2013

PilzAdam Jul 9, 2013

Choose a reason for hiding this comment

Zeg9 commented Jul 9, 2013

PilzAdam commented Jul 11, 2013

Calinou commented Jul 13, 2013

bas080 commented Jul 18, 2013

RealBadAngel commented Jul 23, 2013

proller commented Jul 24, 2013

BlockMen commented Jul 31, 2013

Wuzzy2 commented Aug 13, 2014

EvergreenTheTree commented Aug 13, 2014

nerzhul commented Feb 16, 2015

Zeno- commented Mar 1, 2015

kilbith commented Dec 3, 2015

est31 commented Dec 4, 2015

C1ffisme commented Dec 4, 2015

est31 commented Dec 5, 2015

sapier commented Dec 18, 2015

kilbith commented Dec 18, 2015

ghost commented Dec 29, 2015

ObaniGemini commented Feb 20, 2016

paramat commented May 22, 2016 • edited Loading

paramat commented May 23, 2016 • edited Loading

Wuzzy2 commented May 23, 2016

paramat commented Jun 2, 2016

paramat commented Aug 13, 2017

paramat commented May 22, 2016 •

edited

Loading

paramat commented May 23, 2016 •

edited

Loading