Italian locale file (filename.it.tr) not being loaded

[ghost]

Minetest version

5.0.1

OS / Hardware

Operating system: Debian 9
CPU: Intel(R) Core(TM) i5-3570K CPU @ 3.40GHz (1,60GHz)

Summary

The engine does not use Italian (filename.it.tr) files, while using other languages' files.

Steps to reproduce

1 - update the italian locale file(s) from Weblate - .po .mo
2 - download the Locale Tester [Minetest forum link]
3 - check the tester's output
4 - revert to the old locale file (the one currently bundled with MT)
5 - check the tester's output

Forum's thread: [link]

Screenshot:

[SmallJoker]

The magic translation string is correct in 5.1-dev. Are you sure your translation files are up to date?

#: src/network/clientpackethandler.cpp
msgid "LANG_CODE"
msgstr "it"

[ghost]

The magic translation string is correct in 5.1-dev. Are you sure your translation files are up to date?

I am using v5.0.1
I have created the translation file today.

minetest/src/network/clientpackethandler.cpp

Line 137 in 76325d0

std::string lang = gettext("LANG_CODE");

[SmallJoker]

Works in 5.1-dev.

Try this locale file:
minetest.mo.zip

[ghost]

Works in 5.1-dev.
Try this locale file:
minetest.mo.zip

I've tried your locale file, it changed the Minetest engines' locale, but the mod locale still does not work.

[SmallJoker]

Does the issue persist on 5.1-dev for you? I don't think there was a change in that code but it's worth a try.

[ghost]

Does the issue persist on 5.1-dev for you? I don't think there was a change in that code but it's worth a try.

I've just compiled it, the issue persists.
If I set language = de, it works correctly; if I set language = it, it uses the English description.

[SmallJoker]

Is any other language affected? This seems to be your main language, so those translations should also load if language is not specified in minetest.conf.
What happens if you remove setting line from your configuration? Try to narrow down the issue as close as possible. How about translations of other mods? Using vanilla MTG and one translated mod?

[ghost]

Is any other language affected? This seems to be your main language, so those translations should also load if language is not specified in minetest.conf.

If I do not specify "language" in "minetest.conf" the engine's GUI is in Italian.
I haven't checked other languages, but I will do.

What happens if you remove setting line from your configuration? Try to narrow down the issue as close as possible. How about translations of other mods? Using vanilla MTG and one translated mod?

I will test using MT v5.0.1, MTG v5.0.1 (on Windows, for being double sure that it's not due to some Linux glitch) and a single mod; i.e. a mod adding a node that when punched sends a string to the player.
I will let you know, and I will attach the test mod's zip.

Thank you for your time and help so far. :)

[ghost]

Try to narrow down the issue as close as possible. How about translations of other mods? Using vanilla MTG and one translated mod?

I have created a tester, MT v5.0.1 and MTG v5.0.1 are working as expected.
The tester is available here: [link]

Thank you again. :)

[ghost]

Eventually I have discovered the reason of the issue, it is due to Weblate's updated italian files.
If you use the MT's bundled locale the tester will work as expected.
But if you use Weblate's .po or .mo the locale will fall back to English.

I've tested this with a clean MT v5.0.1 and MTG v5.0.1 installation;
old locale file = test passed;
new locale file = test failed;
rollback to the old locale file = test passed;

Could you try if this is happens to you as well, so that I can be sure that it is not my computer hating me?

[SmallJoker]

But if you use Weblate's .po or .mo the locale will fall back to English.

No wonder if the language code isn't right. Fix the translations.

#: src/network/clientpackethandler.cpp
msgid "LANG_CODE"
msgstr "LANG_CODE"

[ghost]

No wonder if the language code isn't right. Fix the translations.

#: src/network/clientpackethandler.cpp
msgid "LANG_CODE"
msgstr "LANG_CODE"

Ah! Now I got what you meant here #8809 (comment), I thought that you were talking about the C++ source code, not about the locale file.

That string wasn't being shown in POEdit, I've fixed it using the notepad.
Hopefully now it's all ok, thank you again!