Android: replace InputDialogActivity on simple dialog window #10034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
added
Android
Maintenance
|
@rubenwardy, this is a fairly simple PR that has been thoroughly tested at MC. If MT 5.3.1 release with Android specifix fixes is planned, it might be there. |
|
@rubenwardy, maybe you want to test it? Very simple changes, thoroughly tested by MultiCraft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compact, short information about your PR for easier understanding:
Replace the heavy and slowly opening (@nerzhul , see the number of ANRs in the Google Play Console) InputDialogActivity with a very lightweight dialog.
As before. But better and faster, without ANR.
What changed? Now when you press Enter, the text is sent. But when you click on BACK, the input field closes correctly and does not send the changes.
Also fixed the problem when the input field was hidden, and the keyboard remained and overlapped half the screen.
@rubenwardy I'm sure you will like it.
No.
Improving code, optimizing, fixing application freezes.
To do
This PR is Ready for Review.
How to test
Compile Android port. Run. Press on any input field. Enjoy 😎
From MultiCraft with ❤️