Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null bytes from TOCLIENT_BLOCKDATA #10433

Merged
merged 1 commit into from Sep 26, 2020
Merged

Conversation

luk3yx
Copy link
Contributor

@luk3yx luk3yx commented Sep 26, 2020

Add compact, short information about your PR for easier understanding:

  • Goal of the PR

Stop sending two null bytes after every TOCLIENT_BLOCKDATA

  • How does the PR work?

By decreasing the size of the packet by 2 bytes.

  • Does it resolve any reported issue?

#10403

  • If not a bug fix, why is this PR needed? What usecases does it solve?

To do

This PR is Ready for Review.

  • Testing

How to test

Ensure Minetest works correctly and possibly inspect the packet with Wireshark.

@sfan5 sfan5 added Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Sep 26, 2020
@SmallJoker SmallJoker merged commit 09af0c5 into minetest:master Sep 26, 2020
@luk3yx luk3yx deleted the patch-4 branch September 27, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants