-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement get_item_defs() client-side call #10455
Conversation
Do you plan to make another PR for |
👎 I do not like doing this, but i disapprove because i think CSM features should not be accepted until SSCSM is implemented. |
@appgurueu are you gonna continue with this? "Action / change needed" label, will close in 10 days if I receive no answer |
This is now in a mergeable state. Adding |
Closing this because CSMs seem to be a dead end anyways so far (and I will reimplement my online craftguide without requiring clients to render items). Not to mention that this should probably use a shared table to be accessed by all CSM (which would raise the question of how to protect it from writes). |
Logical extension of
get_item_def
, another #10003 split-off.