Better mod naming. #1062
Closed
Better mod naming. #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch does the following: - Allows mod authors to provide a `mod_info.txt' file, to specify the mod name directly (and can later be used for other information about mods). - Strips everything after the first dash. This makes it possible to have the `-master' suffix added by GitHub to the directory name. This should avoid the need to rename the mod folders in most cases (with the first point, in all cases).
|
There's already a file read for information in mod tab maybe we should use a single file for all of those things? |
ghost
assigned 
sapier
force-pushed
the
master
branch
2 times, most recently
from
c7b9cf1
to
c24e075
Compare
ShadowNinja
force-pushed
the
master
branch
4 times, most recently
from
73b8c08
to
56195dc
Compare
sfan5
added
enhancement
and removed
Feature request
|
The second point should be removed because some archives are named
|
Closed
|
👍 You should also update everywhere else to use mod.conf instead of description.txt, keeping backwards compatibility of course. |
|
Someone can review this ? |
|
As discussed with @ShadowNinja on IRC. This issue is partially solved. Commit c5defe7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does the following:
mod.conffile, to specify the mod name directly (and can later be used for other information about mods).-mastersuffix added by GitHub to the directory name.This should avoid the need to rename the mod folders in most cases (with the first point, in all cases).