Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTest: Add item to test replace_with_item in item_eat #10642

Merged
merged 1 commit into from
Dec 18, 2020
Merged

DevTest: Add item to test replace_with_item in item_eat #10642

merged 1 commit into from
Dec 18, 2020

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Nov 17, 2020

This PR does the following thing:

  • A new test item is added to DevTest to test the item replacement feature of minetest.item_eat: testfoods:replace. This calls minetest.item_eat(1, "testfoods:good1").

How to test:

Give yourself testfoods:replace in DevTest. Eat it. It should be replaced with testfoods:good1.

@SmallJoker
Copy link
Member

Works for me 👍

@SmallJoker SmallJoker added @ Devtest Game One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Dec 2, 2020
@SmallJoker SmallJoker merged commit 025035d into minetest:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees
No one assigned
Labels
@ Devtest Game Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wuzzy2 @SmallJoker @rubenwardy