Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocessor check for weird (incorrect) build configurations #11616

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Sep 13, 2021

Minetest would probably compile with -fno-exceptions / -fno-rtti but break in weird, unexplainable ways at runtime.
So a straight error is better.

The used defines are standard: https://en.cppreference.com/w/cpp/feature_test

To do

This PR is Ready for Review.

  • Test on MSVC

@sfan5 sfan5 added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Sep 13, 2021
@sfan5 sfan5 merged commit ad076ed into minetest:master Sep 19, 2021
@sfan5 sfan5 deleted the weird branch September 19, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant