Add proper Lua API deprecated handling #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (doerror) { | ||
| verbosestream << message << std::endl; | ||
|
|
||
| if (L != 0) { |
There was a problem hiding this comment.
Use NULL when comparing pointers.
There was a problem hiding this comment.
sorry forgot about minetest being NULL-land
ShadowNinja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As various discussions about broken lua api revealed we've got need for proper handling of old and sometimes broken lua api calls.
In order to get rid about them we need a way to give mod authors chance to replace them prior removal.
This patch adds (configurable) logging of deprecated functions mod authors are suggested to set
"deprecated_lua_api_handling" to error in order to replace those calls as soon as possible.
Server owners running >>>release build<<< don't need to do anything as legacy handling is done there.
Everyone running >>>debug build<<< will see log messages about deprecated functions, unless having manually set "deprecated_lua_api_handling" to "legacy"