Make the crosshair DPI-aware #13772
Merged
Make the crosshair DPI-aware #13772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
approved these changes
Sep 11, 2023
|
For future reference: As I understand it, this PR may make the provided PNG crosshair blurry, depending on your. DPI. (Or maybe it is already blurry, who knows? Testing things is hard, let's go shopping instead!) |
|
Yes, it may. To avoid that, we could do something like this: 1a81267. There were also arguments against that on IRC, though. Here are the logs: https://irc.minetest.net/minetest-dev/2023-09-11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the crosshair respect DPI and
hud_scaling. This doesn't make any difference on my desktop computer, but on my Android phone, it results in a noticeably less tiny crosshair.desktop,
masterbranchdesktop, this PR (identical)
Android,
masterbranchAndroid, this PR (noticeably less tiny crosshair)
To do
This PR is a Ready for Review.
How to test
Verify that both the object crosshair and the normal crosshair still work, verify that crosshair images still work, verify that
crosshair_colorstill affects crosshair images.Verify that the crosshair is affected by
hud_scaling.