Fix offset being ignored by inventory bar HUD

[rubenwardy]

minetest.register_on_joinplayer(function(player)
    minetest.chat_send_player(player:get_player_name(), "Hello!")
    minetest.after(2, function()
        player:hud_add({
            hud_elem_type = "inventory",
            text = "main",
            number = 3,
            item = 1,
            direction = 2,
            position = {x=0, y=0.5},
            offset = {x=300, y = 100}
        })
        player:hud_add({
            hud_elem_type = "inventory",
            text = "main",
            number = 3,
            item = 2,
            direction = 0,
            position = {x=0, y=0.5}
        })
    end)
end)

[rubenwardy]

Just look at the code, the offset is never used.

[Zeno-]

Why the superfluous parenthesis?

[rubenwardy]

I just changed the existing code, but I'll fix that.

[rubenwardy]

@sapier, please may you check that the scaling works on this?

[KenneyNL]

What's the status on this? Just tried it in the latest version and offset still does absolutely nothing.

[rubenwardy]

I was waiting for @sapier to test the scaling, as I'm unsure whether it works correctly.

[est31]

Requesting the setting? Twice? Best, it should be cached somewhere, retrieving settings with the hashmap isn't fast at all.

[rubenwardy]

Fixed, rebased and ready for review.

[rubenwardy]

Bump, is it worth rebasing this?

[rubenwardy]

Rebased and ready for review

[paramat]

Yes it's worth rebasing, thanks, sorry it was neglected.

[rubenwardy]

Rebased and code style fixed
Added minimal test example to start post.
Whilst rebase, I noticed a bug: #3970

[paramat]

I assume the bug is fixed by this PR?

[rubenwardy]

That rendering bug is present both before and after my PR. Currently working out the cause.

[sofar]

Read the code change, and this is almost trivial. The actual effective change is maybe 3 lines, the rest are all cleanups or passing the parameter around the function calls.

[rubenwardy]

Graphics bug moved to here: #3970

[sfan5]

👍

[paramat]

Code reviewed @rubenwardy is this tested? if so +1.

[rubenwardy]

I've tested this, and it makes the attached code example work.

[paramat]

👍

[kwolekr]

Why is offset a const ref while upperleftpos isn't? Please make both a const ref, or pass offset by value.

[est31]

I dont think this makes that much sense any way... sizeof(v2s32) == 8 so on 64 bit architectures the pointer isn't smaller than the actual data. This means an extra level of indirection, which is bad, and for (almost) no use.

[kwolekr]

Yea, I'm just going to change this while merging...

[kwolekr]

👍

[kwolekr]

eae3395