Fix bug that disabled game-based minetest.conf default setting #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code also has to run when initializeWorld is called by the main menu so that mapgen parameter defaults are initialized. |
| Settings game_defaults; | ||
| getGameMinetestConfig(gamespec.path, game_defaults); | ||
| override_default_settings(g_settings, &game_defaults); | ||
|
|
There was a problem hiding this comment.
This should stay where it was below.
There was a problem hiding this comment.
its not part of the world initialisation.
est31
force-pushed
the
fixgameconf
branch
2 times, most recently
from
46138e8
to
5071ce5
Compare
This was a regression introduced by f6e4c5d .
This is neccessary as executing different games after each other, in the same instance, cluttered up the settings space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit f6e4c5d caused this.