-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua settings improvements #3271
Conversation
@PilzAdam You've cancelled (at least) 9d21fa3 with 5675486. |
@kilbith Thanks for spotting that; I checked everything else now. |
Everything important is now done here, except the support for grouped noise param settings, but this is due to a missing Lua API functionality for grouped settings (or structs). The only things missing from the list in #3266 are fancier input dialogs for certain types, but that's not so high priority. I think this can be merged now. |
@@ -29,6 +31,11 @@ | |||
# - default (if default is not specified then "" is set) | |||
# * key: | |||
# - default | |||
# * flags: | |||
# Flags are always comman seperated without spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo; will fix.
Really great idea to scan for |
For modders and game creators: should we add documentation for how to automatically generate minetest.conf.example for mods/games from settingstypes.txt? |
@est31 addressed all your remarks. If we want to expose the generation of I would personally prefer a way to pass command-line options to the main menu (maybe with registering them first, so they can be printed in |
# If enabled together with fly mode, player is able to fly through solid nodes. | ||
# This requires the "noclip" privilege on the server. | ||
noclip (Noclip) bool false | ||
|
||
# Smooths camera when moving and looking arround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"around"
New notes for map_generation_limit for settingtypes.txt and minetest.conf.example. "Map generation is limited to this distance in nodes from (0, 0, 0), |
Thanks for all your suggestions on |
Cool. For the moment don't worry too much about the setting of noise parameters, as this is advanced stuff that can always be done using minetest.conf.example. |
Don't edit that file anymore. If you want to change something in minetest.conf.example, edit settingstypes.txt instead, and @PilzAdam will generate minetest.conf.example with automated tools. |
da13647
to
6732fd6
Compare
* Add key settings to setting table and ignore them later This way they are added to the auto-generated minetest.conf.example * Add flags type * Add input validation for int, float and flags * Break in-game graphic settings into multiple sections * Parse settingtpes.txt in mods and games * Improve description for a lot of settings * Fix typos and wording in settingtypes.txt * Convert language setting to an enum
6732fd6
to
6f2d9de
Compare
Changes:
minetest.conf.example
flags
now fully supported with a list of possible valuesint
,float
andflags
types (type safety and min / max checks)settingtypes.txt
files are passed from games and mods root folders; they are displayed in special categories.noise_params
type