Thread: fix a crash on Windows due to data race condition on Thread::m_start_finished_mutex #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_start_finished_mutex
sfan5
reviewed
Oct 10, 2017
| // Unlock m_start_finished_mutex to prevent data race condition on Windows. | ||
| // On Windows with VS2017 build TerminateThread is called and this mutex is not | ||
| // released. We try to unlock it from caller thread and it's refused by system. | ||
| thr->m_start_finished_mutex.unlock(); |
There was a problem hiding this comment.
shouldn't this be inside an #ifdef _WIN32 then?
There was a problem hiding this comment.
on android it's also undefined behaviour, we use pthread_kill, and it's better to do it properly
|
Approved by @sfan5 on IRC: http://irc.minetest.net/minetest-dev/2017-10-10#i_5105037 |
sfan5
pushed a commit
that referenced
this pull request
Nov 19, 2017
…m_start_finished_mutex (#6515)
Closed
t0ny2
pushed a commit
to t0ny2/minetest
that referenced
this pull request
Jan 23, 2018
…m_start_finished_mutex (minetest#6515)
sfan5
pushed a commit
that referenced
this pull request
Apr 21, 2018
…m_start_finished_mutex (#6515)
sfan5
pushed a commit
that referenced
this pull request
May 13, 2018
…m_start_finished_mutex (#6515)
SmallJoker
pushed a commit
that referenced
this pull request
Jun 3, 2018
…m_start_finished_mutex (#6515)
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
…m_start_finished_mutex (minetest#6515)
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
…m_start_finished_mutex (minetest#6515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_start_finished_mutex is not unlocked by thread when exiting the thread::run function.
On windows TerminateHandle kill the thread but doesn't release mutexes owned by it, it's a dangerous function.
On VS2017 when calling Thread destructor and trying to unlock, it's refused by system because mutex is not owned by this thread.