Biome API / cavegen: Add definable cave liquid for a biome #7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramat
added
@ Script API
@ Mapgen
WIP
Feature ✨
|
Testing with 4 very small scale biomes, to test change within a single large cave:
|
|
Added docs, ready. |
paramat
commented
Apr 4, 2018
| getintfield(L, index, "y_min", b->min_pos.Y); | ||
| b->max_pos = getv3s16field_default(L, index, "max_pos", v3s16(31000, 31000, 31000)); | ||
| b->max_pos = getv3s16field_default( | ||
| L, index, "max_pos", v3s16(31000, 31000, 31000)); |
There was a problem hiding this comment.
The above is just splitting long lines.
|
Build fail is Travis error. |
Add 'node_cave_liquid' as a new field in biome registration. If field is absent cave liquids fall back to classic behaviour.
SmallJoker
approved these changes
Apr 5, 2018
Closed
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
…7192) Add 'node_cave_liquid' as a new field in biome registration. If field is absent cave liquids fall back to classic behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7181
Integrates (at last) large pseudorandom cave liquids into the Biome API.
New biome field 'node_cave_liquid' added.
For each segment of a large cave the code gets the biome at (X, Y, Z) point.
If 'node_cave_liquid' is stated for that biome, it is used, otherwise falls back to classic hardcoded behaviour (lava or water according to a hardcoded 3D noise).