Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ContentDB packages timing out by using download_file instead #7891

Merged
merged 2 commits into from Dec 11, 2018
Merged

Fix ContentDB packages timing out by using download_file instead #7891

merged 2 commits into from Dec 11, 2018

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Nov 25, 2018 •
edited

Fixes #7447

@rubenwardy rubenwardy added Blocker The issue needs to be addressed before the next release. High priority @ Mainmenu labels Nov 25, 2018
@rubenwardy rubenwardy added this to the 5.0.0 milestone Nov 25, 2018
@rubenwardy rubenwardy mentioned this pull request Nov 25, 2018
Closed
ClobberXD
ClobberXD approved these changes Nov 25, 2018
View reviewed changes
Copy link
Contributor

@ClobberXD ClobberXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Packages are correctly fetched 10/10 times. 👍

@rubenwardy rubenwardy closed this Nov 25, 2018
@rubenwardy rubenwardy deleted the contentdbpackages branch November 25, 2018 15:58
@rubenwardy rubenwardy restored the contentdbpackages branch November 25, 2018 16:40
@rubenwardy rubenwardy reopened this Nov 25, 2018
This was referenced Nov 28, 2018
Merged
Closed
@paramat
Copy link
Contributor

paramat commented Nov 30, 2018 •
edited

Seems to work, takes 4s for me to first enter package menu.
It creates folders in my computer's 'tmp' folder. I have several folders named like:
/tmp/MTTempModFolder_3018 which gradually fill up with images as i browse through the package list. A new folder is added every time i run MT.

@rubenwardy rubenwardy mentioned this pull request Dec 1, 2018
Closed
@rubenwardy
Copy link
Member Author

It creates folders in my computer's 'tmp' folder. I have several folders named like:
/tmp/MTTempModFolder_3018 which gradually fill up with images as i browse through the package list. A new folder is added every time i run MT.

This is also the case with current master

@paramat paramat mentioned this pull request Dec 3, 2018
Closed
@paramat
Copy link
Contributor

paramat commented Dec 11, 2018 •
edited

👍 not an expert on file stuff but code seems ok and you're the expert, i think it's important this gets merged for testing soon.

@paramat paramat merged commit f318366 into minetest:master Dec 11, 2018
@paramat paramat removed this from PR in Minetest 5.0.0 blockers Dec 11, 2018
@rubenwardy rubenwardy deleted the contentdbpackages branch December 11, 2018 12:19
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@rubenwardy @osjc
Fix ContentDB packages timing out by using download_file instead (min…
2c3418a 
…etest#7891)
luk3yx pushed a commit to luk3yx/minetest that referenced this pull request Feb 16, 2019
@rubenwardy @luk3yx
Fix ContentDB packages timing out by using download_file instead (min…
f2ac145 
…etest#7891)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker left review comments

@ClobberXD ClobberXD ClobberXD approved these changes

Assignees
No one assigned
Labels
Blocker The issue needs to be addressed before the next release. @ Content / PkgMgr High priority @ Mainmenu One approval ✅ ◻️
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rubenwardy @paramat @SmallJoker @ClobberXD