Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Github templates #8593

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Update Github templates #8593

merged 1 commit into from
Jun 13, 2019

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Jun 11, 2019 •
edited
Loading

This allows users to choose between feature request and bug when creating an issue

@rubenwardy rubenwardy added @ Documentation Improvements or additions to documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Jun 11, 2019
@rubenwardy rubenwardy force-pushed the rubenwardy-issue-templates branch 2 times, most recently from 4c09f52 to 7d0d867 Compare June 11, 2019 17:20
@rubenwardy rubenwardy changed the title Add multiple issue templates Update Github templates Jun 11, 2019
@rubenwardy rubenwardy force-pushed the rubenwardy-issue-templates branch 2 times, most recently from 50cf29f to f7ecedd Compare June 11, 2019 17:22
@rubenwardy rubenwardy assigned nerzhul and unassigned nerzhul Jun 11, 2019
@rubenwardy rubenwardy requested a review from nerzhul June 11, 2019 17:23
SmallJoker
SmallJoker reviewed Jun 11, 2019
View reviewed changes
.github/SECURITY.md Outdated Show resolved Hide resolved
@paramat
Copy link
Contributor

paramat commented Jun 11, 2019

I think the 'feature request' needs a 'why this is needed and/or why this will be useful' section, as that is so often forgotten by the authors.

@rubenwardy
Copy link
Member Author

rubenwardy commented Jun 11, 2019 •
edited
Loading

Done.

Also, are there any other types of issue other than Feature Request and Bug Report which make sense to have their own template?

SmallJoker
SmallJoker approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenwardy rubenwardy merged commit f2c73de into master Jun 13, 2019
@rubenwardy rubenwardy deleted the rubenwardy-issue-templates branch June 16, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

@nerzhul nerzhul Awaiting requested review from nerzhul

Assignees
No one assigned
Labels
@ Documentation Improvements or additions to documentation One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubenwardy @paramat @SmallJoker @nerzhul