FormSpec: Support custom size and spacing for slots in list (#7971) rebased #9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2019
|
Ok it's fixed now. Ready for review. |
|
This will need to be reworked to support styling, and also use the new class for inventory lists |
|
Sorry, I'm dropping this PR, I don't have time for this because of OpenMiner. |
v-rob
moved this from PRs: Highest priority on top
to Adoption needed or rejected
in Formspec Priority List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7971, I just rebased it in another branch to make things easier for me.
There is a small problem with this one after rebase though, when resizing craft preview over it's original size, the square will stay the same size but the item inside will scale up. I don't understand why it's happing because it's the only slot with an issue, other slots are fine.I tried to make the exact same changes in the files and I don't remember much about how this PR works, especially because I wasn't the original author.