-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact image-generation texture modifier #9767
Conversation
I wonder if there isn't a better solution to dynamically generated images. |
There most likely is, but not without much effort. |
I suggest having PNG data in the same way that data URLs work, constructed with a helper on the server It would be nice to fix texture caching to not cache everything when doing stuff like this, though |
raw_image sounds better than image for me, as we are low level here |
So propose |
👎 this PR should either implement a modifier for raw image data, or image data encoded as base64. |
Closing this in favor of @sfan5's PR. |
Unless i missed something, I wasn't aware that the other PR allowed for programmatic generation of textures. From my reading, it implements pushing of already existing media files to the client, which is completely different. |
I believe this PR still can serve a purpose. This allows highly customizable textures, working for things like e.g. painting or sign mods. You could, I suppose, create a PPM image, save it with a cryptic name like Personally, I think using a hexadecimal color string for each pixel is overkill though. Offering a palette modifier would also be a good solution, like |
Status
This PR is Ready for Review.
How to test
Results in this: