New shelf overlays don't line up

[ghost]

@sofar are you having a laugh? :)

In my own personal opinion, 0acd9a2 is distasteful.

[ghost]

Additionally, not all books are shaped the same.

Undoubtedly, the same could be said for vessels.

[Desour]

these are there because Sam put so often the same shape of book there
its damage caused by using it
=> the shape doesn't have to suit

[sofar]

I see no issue.

The backdrop is suggestive, and meant as such. On top of that, mods that change book shapes can provide alternative textures, and so can texture packs. A texture pack could entirely remove the effect as well.

[Ferk]

I don't think they necessarily need to match the same shape as the item.
But maybe the contrast could be reduced a bit more so that they fade in the background and don't interfere too much with the actual item image.

[Wuzzy2]

It seems the background has an offset of exactly 1 pixel to the right, compared to the item image.

[paramat]

Looks bad and i had not thought about alternative shaped books. I should have opposed this, sorry. Even if everything lined up it's visually messy and unnecessary extra code and textures, it's fairly obvious a bookshelf is for books and a vessels shelf is for vessels, if not obvious a player will soon find out other items don't apply.
Unfortunately i wrote i didn't care about vessels shelf (thinking we were going to remove it). I suggest reverting the commit.

[ghost]

I think a icon should be hidden when its slot has a item.
(I don't know the following code is workable.)
http://pastebin.com/JPCJusrG

[stujones11]

@Rui-Minetest I am sure it is workable but perhaps a little overkill for such a simple feature. I would be happy enough if they were aligned correctly with the matching images and darkened down slightly to be less noticeable with non-matching images.

[ghost]

The issue, I find, is that the background overlay, which is always present, doesn't necessarily match some item -- or that it may match one item, but not another. Basically, there are different kinds of vessels (group:vessel) and books (group:book).

[stujones11]

The books and vessels in mtg would look pretty much okay with my above recommendations. The images supplied by third party mods that do not fit are the fault of the modder, IMO

[ghost]

The images posted in the issue are not third party mods. #1359 (comment)

[ghost]

Also, it may not matter one iota, but that doesn't negate the fact that things don't line up. I may be particular here, but I'm not wrong. laugh

[paramat]

I also don't like how a new overlay has to be made for a new book texture, if lining-up is wanted.
I might make a PR to revert this.

[stujones11]

I might make a PR to revert this.

@paramat I think that is probably the best idea for now, maybe place-holders could be added as a more generic feature using @Rui-Minetest's method of only displaying them on empty slots. Either way the current look is completely unacceptable.

[paramat]

This has added some complexity, and extra textures, for no good reason and looking worse as a result.
Making the icons disappear when an item is added is even more complexity.

We don't need icons for furnace either, the flame above the lower slot makes it clear the lower slot is for fuel and the upper for what is being smelted.

[Wuzzy2]

This has added some complexity, and extra textures

This is a valid reason to reject almost anything. xD Also, there were far bigger PRs with far more textures. This PR included only 2. I think this argument is pretty weak.

for no good reason

No. The reason was to make the purpose of the slots a little bit more obvious. IMO it is not obvious that a bookshelf is only for storing books. In the real world, a bookshelf is just a shelf and you can store other stuff than just books in it. Of course the player might find out eventually, but the idea here is “being nice to the user”.

looking worse as a result

OK. This is a valid argument, but only against this particular implementation. What would be the right way to do it graphically?

I think the biggest problem is the “one pixel off” problem. This problem seems to come from the engine and there is nothing Minetest Game can do about it (for now). And there is no way to pixel-perfectly align formspec elements. Minetest formspec coordinates are a big mess anyway. :-(

We don't need icons for furnace either, the flame above the lower slot makes it clear the lower slot is for fuel and the upper for what is being smelted.

How can you claim that you know that it “makes it clear”? You are not a Minetest Game newbie. You should ask newbies if you want to be sure. I can recall when I first played Minetest-c55 (many MANY years ago), I would probably not have understood what the furnace slots mean if I would not have read the wiki. I agree, the flame is an important improvement but I am not sure if it would have been enough. I guess the furnace might need a different approach to make it more obvious, I don't think icons alone would help. But anyways, the furnace is a bit off-topic here.

[paramat]

Many MTGame devs like this so i doubt it will be reverted and i don't think i'll try.

I've never seen a complaint about how a newbie suffered due to lack of slot icons, it only takes a few seconds to learn through trial and error.

Please can the slot textures have less contrast?

[Wuzzy2]

Please can the slot textures have less contrast?

This is an excellent idea! See PR #1370. :-)

I think the darker icon color practically fixes this issue as the effect of the icons not lining up pixel-perfectly is now too subtle to be noticed.

[paramat]

#1370 merged which helps.
#1372 if merged will fix this issue completely.

[rubenwardy]

#1372 was merged