New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have beds to depend necessarily on red dye? #475
Comments
IDEA : Why not make the simple bed white, and the fancy bed red? Then the simple bed can be used for simple sleeping, and the fancy one for decoration when you find a rose! |
That can be a good compromise too. |
The problem is making a white bed that looks good. I don't think I would want to sleep in a white bed. So someone has to make a REALLY good texture. Or, since leaves are pretty much everywhere, why not make leaves (or cactus) make a green dye, which can make the simple bed. |
The Way To Go is different coloured beds like the old-style beds. |
@0-afflatus True, but then we have to add a whole bunch of nodes. And people really don't need that many in-game. It's better to have 1 or 2 beds and stick with that. Maybe if we had a bed that could be dyed via crafting, while the colored types didn't appear in the creative inventory. Maybe different colors of bed could be defined by a param. We just need a non-heavy, not-to-many-node solution. Or we could go the minecraft way, where every wool makes a bed. Cheap, but might work just for gameplay reasons. |
@C1ffisme Making all wool result in the same bed would break my beds mod, since the generic recipe would override the color-specific ones. |
@PilzAdam I believe your beds mod would override the minetest one, overriding the crafting recipe. So actually nothing would happen to your mod, because of naming conventions. |
Personally, the old coloured bed models with the new functionality would suit me fine. And I might just do that if it is not too complicated. I'm not sure this discussion is really going anywhere. |
@C1ffisme this is not specified behavior, so we have to assume the worst case. Maybe add a way in the engine to remove / override recipes. |
@PilzAdam I saw an engine issue about that. |
I like white beds. It kind of harken back to days on the farm where they
|
@PilzAdam huh? Except some 0.4.5 or 0.4.6 dev version user mods with the same name did always replace the game mods... |
@BlockMen why do you provide an API to add new beds when mods that want to add new beds have to override it? |
@PilzAdam i ment there general behavior of mods. |
@BlockMen it's not about my mod. A mod that wants to add beds for all colors using the API you provide would depend on unspecified behavior regarding the crafting recipes. |
What about giving it a different name? "morebeds" could add new ones depending on default "beds" without overriding it, as moreores does not override default ores. |
@PilzAdam you can use any recipe. only the recipe for the default beds is fixed. @Echoes91 I don't see the point in renaming. The reason that there are "only" two beds is that Minetest Game should not get bloated. If ppl want more colors, a mods could easily add by using the API. And yeah, one solution would be a white bed or a "raw" bed that could get crafted with any kind of wool and dyed afterwards. But first i think a white bed wouldnt look good and second it would be even more confusing than now IMO. |
I meant to give a different name to the mod that should add more beds, so that it can use the default mod's API without overriding it. And the raw/white bed should be crafted only with the raw white wool, without overriding any colored bed or creating any confusion. |
I wonder... what if we could set the texture of the bed based on a parameter, and not make several nodes of beds? I'm not sure if this is possible, but if this could be done, you can just see all the node types we could save. Wool could be 1 node type, metal blocks could be 1 node type, desert and normal stone could be 1 node type, we would just need two things:
You can see how useful this feature would be in mods. |
Removed color dependency in Minetest NeXt. |
|
OK I'm going to look for a different solution for night-skip voting as using the beds mod from minetest_game in grailtest isn't satisfying my requirements. AFA decor is concerned, players can do interesting things with coloured wool. I think I want to de-couple night-skip voting from this. I'll stop making comments on this issue as minetest_game isn't really my concern. |
I'm thinking either a range of coloured beds, plus a white one needing no dye, as beds are part of a builds furniture. |
This is why the difficulty argument is no issue, not needing a dye doesn't really make them easier to craft. The locations of biomes means that you are highly likely to pass a rose by the time you find a jungle for cotton seeds. I suggest a white bed from:
I will probably make the texture and a PR soon. |
Sweet! Thanks a lot! |
Thinking on this, i'm sure many like the red beds, so the thing to do would be to add white beds (or maybe just the simple one) without removing the red ones. |
I'll register a 'simple white bed' soon, any comments or objections? |
Just feel like mentioning it... but MC recently added colored beds to their game. Although even they didn't have enough block IDs for it, and the colored beds are actually tile entities... |
We are considering that, there's a PR that might be reworked to do that but the author is absent, so in the meantime this will be a simple quick fix. |
|
PR #2150 |
More opinions needed on a solution, @Ezhh ? |
I'm rather indifferent about beds in general, and wondering why some people are against adding a white bed. I do feel adding all colours isn't necessary for MTG itself. |
How about making the red bed not require red dye as a simple fix? After all most of the bed is the mattress which can be considered white wool. We have many items with coloured components that don't use a dye. Recipe conflicts: |
No objection to removing the requirement for dye. I'm not familiar with the mod you're referring to, but most mods are intended for use with MTG, so please don't rule that out unless you've checked (though generally we shouldn't be restricted based on what another non-MTG mod has done, it's still good practice not to break something that already exists when we're aware of a possible issue). |
Hmm, in this case the mod is very much MTG beds mod code modified, instead of something meant to be parallel, so i think it's the responsibility of the mod to work around MTG. If we merge my suggestion i'll make a post in the mod thread. https://forum.minetest.net/viewtopic.php?t=18775 |
PR #2309 |
We know that colored beds are nicer, and also that red wool should come out from red dye, but why should somebody stay awake every night until he finds a rose? The bed should have worked the same whatever the color of the wool was.
I can imagine that defining and drawing textures for each color like the good old PilzAdam's work may be boring and low priority, that's why i have two proposals: either fall back to the Minecraftish solution where every wool color gives the same red bed (it may be one of the worst things to copy but after all why the bed is red if not due to MC?), or we can make the bed white. White bed could be crafted coherently with white wool, thus not depending on any flower species, and also look more sober (I think MT feels overall more sober than MC).
What do you think? If you like either one or the other one i can make a PR.
Sorry for the long writing...
The text was updated successfully, but these errors were encountered: