Farming: Deprecate bronze, mese and diamond hoes. Tune steel uses

[paramat]

Attends to #1252 and partially attends to #1681
Simpifies the long-criticised excessive number of hoe tiers.

"The following are deprecated by removing the 'material' field to prevent
crafting and removing from creative inventory, to cause them to eventually
disappear from worlds. The registrations should be removed in a future
release."

Gives steel hoes 500 uses, equal to previous diamond hoes, to compensate for the extra work needed to create a steel hoe. This attends to the issue of more valuable materials not being worth using #1252

Hoes are fairly insignificant so i doubt there will be much mod breakage (if mods rely on certain hoes in recipes). There is, amazingly, an API for registering hoes so it's easy for mods to register what they want.
If merged i will add a news thread to the forum to warn of the change.

[Sokomine]

Can't hurt to do it this way. As a hoe is needed only once per field node, the cheapest material (usually cobble) is sufficient, while steel hoes might still be useful for decorative purposes.

[paramat]

Maybe the uses of steel hoe could be even higher, as it is a lot more work to create one, possibly 500 to be equal to the diamond hoe? That's still only 2 mapblocks of field.

[Ezhh]

Removing material doesn't prevent a recipe being registered. You should prevent a recipe registering in the event that material is not defined, otherwise this will be an issue if we ever add a craft guide (and already will be if people add one themselves).

[paramat]

Ok. Yes i wondered if the 'air' recipe would be a problem.

[Ezhh]

For example, if you use crafting guide with this, you get:

This is clearly not ideal because people will see this even though it's senseless. If you give yourself air you can also get:

[Ezhh]

Another thing: If you plan to ever remove them fully, it would be good to also remove them from creative inventory.

[SmallJoker]

minetest_game/mods/farming/api.lua

Lines 106 to 121 in 11b3407

	-- Register its recipe
	if def.material == nil then
	minetest.register_craft({
	output = name:sub(2),
	recipe = def.recipe
	})
	else
	minetest.register_craft({
	output = name:sub(2),
	recipe = {
	{def.material, def.material, ""},
	{"", "group:stick", ""},
	{"", "group:stick", ""}
	}
	})
	end

->

if def.recipe and not def.material then
	minetest.register_craft({
		output = name:sub(2),
		recipe = def.recipe
	})
elseif def.material then
	minetest.register_craft({
		output = name:sub(2),
		recipe = {
			{def.material, def.material, ""},
			{"", "group:stick", ""},
			{"", "group:stick", ""}
		}
	})
end

Solution for the hacky air workaround.

[paramat]

Thanks will do all suggestions.

[paramat]

@SmallJoker see earlier in the code, if def.recipe is nil it is defined with "air". I don't know why. Not sure i can avoid "air" recipes in a craft guide.

[benrob0329]

Air hoes 🤔

[paramat]

60ccb52#diff-219f47a35d69ed92c4ed83e9afa809f9
Air recipe wa defined to have a recipe here, but may not be needed now.
Will fix.

[paramat]

Updated, now testing.

[paramat]

Works, now to remove from creative inventory.

[paramat]

Done.
Gives steel hoes 500 uses, equal to previous diamond hoes, to compensate for the extra work needed to create a steel hoe. This attends to the issue of more valuable materials not being worth using #1252

[Ezhh]

Tested, recipe and creative inv issues are fixed. :)
I'm also fine with switching steel to 500.

👍

[Fixer-007]

Seems nice

[Fixer-007]

Needs write up in the news section, probably (for modders)

[paramat]

I'll do that next time i sign-in to the forum, on todo list.