-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farming: Deprecate bronze, mese and diamond hoes. Tune steel uses #2103
Conversation
Can't hurt to do it this way. As a hoe is needed only once per field node, the cheapest material (usually cobble) is sufficient, while steel hoes might still be useful for decorative purposes. |
Maybe the uses of steel hoe could be even higher, as it is a lot more work to create one, possibly 500 to be equal to the diamond hoe? That's still only 2 mapblocks of field. |
farming.register_hoe(":farming:hoe_bronze", { | ||
description = "Bronze Hoe", | ||
inventory_image = "farming_tool_bronzehoe.png", | ||
max_uses = 220, | ||
material = "default:bronze_ingot" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing material doesn't prevent a recipe being registered. You should prevent a recipe registering in the event that material is not defined, otherwise this will be an issue if we ever add a craft guide (and already will be if people add one themselves).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Yes i wondered if the 'air' recipe would be a problem.
Another thing: If you plan to ever remove them fully, it would be good to also remove them from creative inventory. |
minetest_game/mods/farming/api.lua Lines 106 to 121 in 11b3407
-> if def.recipe and not def.material then
minetest.register_craft({
output = name:sub(2),
recipe = def.recipe
})
elseif def.material then
minetest.register_craft({
output = name:sub(2),
recipe = {
{def.material, def.material, ""},
{"", "group:stick", ""},
{"", "group:stick", ""}
}
})
end Solution for the hacky |
Thanks will do all suggestions. |
@SmallJoker see earlier in the code, if def.recipe is nil it is defined with "air". I don't know why. Not sure i can avoid "air" recipes in a craft guide. |
Air hoes 🤔 |
60ccb52#diff-219f47a35d69ed92c4ed83e9afa809f9 |
Updated, now testing. |
Works, now to remove from creative inventory. |
Remove unnecessary "air" fallback recipe for hoes to avoid this showing in crafting guides.
Done. |
Tested, recipe and creative inv issues are fixed. :) 👍 |
Seems nice |
Needs write up in the news section, probably (for modders) |
I'll do that next time i sign-in to the forum, on todo list. |
Attends to #1252 and partially attends to #1681
Simpifies the long-criticised excessive number of hoe tiers.
"The following are deprecated by removing the 'material' field to prevent
crafting and removing from creative inventory, to cause them to eventually
disappear from worlds. The registrations should be removed in a future
release."
Gives steel hoes 500 uses, equal to previous diamond hoes, to compensate for the extra work needed to create a steel hoe. This attends to the issue of more valuable materials not being worth using #1252
Hoes are fairly insignificant so i doubt there will be much mod breakage (if mods rely on certain hoes in recipes). There is, amazingly, an API for registering hoes so it's easy for mods to register what they want.
If merged i will add a news thread to the forum to warn of the change.