Make default:snow collisionbox half of nodebox height #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this, its subtle, but I think its noticeably better now. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ PR
Modification of #2133
Previously, players (and all objects) sank into default:snow by 3/4 the nodebox thickness.
But i noticed that the collisionbox was so thin that when walking onto and off default:snow there was almost no noticeable vertical motion, making it feel like the snow was not there at all. This has always felt wrong.
This PR makes objects sink into default:snow by 1/2 the nodebox thickness.
There is now significant and very noticeable vertical motion when walking onto and off default:snow.
Note that players still do not contact low-hanging pine needle nodes above them, so this does not cause any obstruction when walking through the taiga biome.