Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the listring functionality #542

Closed
wants to merge 1 commit into from
Closed

Add the listring functionality #542

wants to merge 1 commit into from

Conversation

Amaz1
Copy link
Contributor

@Amaz1 Amaz1 commented Jun 16, 2015

This makes chests, locked chests, the creative inventory and the craft grid work with minetest/minetest@c977fbd

Bookshelves and vessel shelves also work nominally with it, but because both of those only allow one item per slot, shift+click seems to fail... I'm fairly certain this is an engine problem, so should I remove the listring code for those two items?

@est31
Copy link
Contributor

est31 commented Jun 16, 2015

They should work agree, leave them in.
Its an engine bug. This can again either solved by super good prediction (wont happen I think, because info has to be transferred), or by better command sending to server (needs change in protocol). Second option is simpler I think.

@est31
Copy link
Contributor

est31 commented Jun 16, 2015

👍

@Ekdohibs
Copy link
Member

👍 :)

@ShadowNinja
Copy link
Member

👍

@est31
Copy link
Contributor

est31 commented Jun 23, 2015

7361eb5

@est31 est31 closed this Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants