Allow for proper template cache busting 🎉 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deprecation warning: DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `conditional-compile-template`.
|
Can also confirm that it appears to fix #21 🎉🎉 I have tested in both development and production environment with different flags enabled. And from what I can tell when using the template feature-flags, it doesn't seem to struggle with the HTMLBars cache anymore 😀 |
|
Oh wow! This is great. I'll review this today and merge ASAP. Thanks so much! |
|
wow that's exciting! |
|
Shipped in 0.4.13. Thanks so much @oscarni! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
ember-cli-htmlbarswas updated with proper cache busting ember-cli/ember-cli-htmlbars#90 so now we can work with template flags in a consistent and reliable way!This tiny PR fixes #21 !!!!
This PR is based on changes that resolves the same issue in this addon adopted-ember-addons/ember-cp-validations#305
Cheers guys! 🍻