-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure logging #1140
Configure logging #1140
Conversation
75cb18f
to
17b4352
Compare
The tenant CRD became corrupt with empty data:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase and address bug
If the tenant doesn't have a
|
portal-ui/src/screens/Console/Tenants/TenantDetails/EditTenantLogsModal.tsx
Show resolved
Hide resolved
f841f84
to
9929bd4
Compare
6715bf6
to
32d433a
Compare
portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx
Outdated
Show resolved
Hide resolved
d7f0e23
to
9bc7fe7
Compare
portal-ui/src/screens/Console/Tenants/TenantDetails/EditTenantLogsModal.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Tenants/TenantDetails/KeyPairEdit.tsx
Outdated
Show resolved
Hide resolved
0f1d115
to
acfb498
Compare
7a391f4
to
6ee586c
Compare
</td> | ||
<td>{logInfo?.serviceAccountName}</td> | ||
</tr> | ||
<h4>Labels</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: validateDOMNesting(...): <h4> cannot appear as a child of <tbody>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these html elements must be inside a column, it's invalid html if they are inside the body of the table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adfost please check why the request is triggering twice when someone click on the logs menu I have seen a similar behavior on other sections of the application, we are doing exactly the same request twice |
0f0580a
to
233601b
Compare
6719adb
to
58ada4f
Compare
8cf4b68
to
8d576e7
Compare
my tenant doesn't specify a log search image, if I edit and save, the default image is stored in the tenant CR, it shouldn't so that this version is updated with the operator
|
e3f8060
to
9d21ddf
Compare
9d21ddf
to
29ae9db
Compare
Add Tenant Logs view and edit modal