Fixed broken oauth2 login for operator #1217
Conversation
Alevsk
requested review from
dvaldivia,
jinapurapu,
aead,
adfost,
harshavardhana and
bexsoft
|
Some integration tests are failing with MinIO @Alevsk |
These tests are failing on master already, I'll investigated why they are failing |
No they are not @Alevsk https://github.com/minio/console/runs/4174881009?check_suite_focus=true - I ran them a few times already. |
You can test locally |
I'm looking at this right now |
Alevsk
force-pushed
the
login-fix
branch
3 times, most recently
from
d9251b3
to
0a036d5
Compare
This PR includes many fixes and refactors for oauth2 authentication and login endpoints, ie: - Invalid login returns `403` instead of `500` error - Removed the session token from console/operator `user credentials login`, `oauth flow login` and `change-password` api responses - Removed session token from localStorage - Added styles for oauth_callback page and display more descriptive errors for debugging - Success logins returns `204` instead of `200` - Removed unused swagger apis and code from both, operator and console projects - Operator `Oauth2` login flow was not validating anything, now it does Signed-off-by: Lenin Alevski <alevsk.8772@gmail.com>
This PR includes many fixes and refactors for oauth2 authentication and
login endpoints, ie:
403instead of500erroruser credentials login,oauth flow loginandchange-passwordapi responseserrors for debugging
204instead of200projects
Oauth2login flow was not validating anything, now it doesError on
oauth_callbackpage beforeError on
oauth_callbackpage nowSigned-off-by: Lenin Alevski alevsk.8772@gmail.com