Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securizing bucket tags #1249

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Securizing bucket tags #1249

merged 1 commit into from
Nov 23, 2021

Conversation

adfost
Copy link
Contributor

@adfost adfost commented Nov 22, 2021

Bucket tags and/or edit/delete bucket tags disappear when user does not have those permissions.

Alevsk
Alevsk previously approved these changes Nov 23, 2021
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please help us to remove this warning?
Screen Shot 2021-11-22 at 20 45 07

Beside of that comment, LGTM

@adfost adfost dismissed stale reviews from Alevsk via e138f41 November 23, 2021 06:30
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with following policies for a user:

  • Deny Tagging ( No Read/Write)
  • Read only Tagging ( Read)
  • Full Tagging ( Read/Write)

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 6b3ff10 into minio:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants