Fix for issue #1390 caused by secure component having multiple childs #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
Alevsk,
cniackz,
adfost,
prakashsvmx,
kaankabalak,
bexsoft and
jinapurapu
…hilds Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
bexsoft
requested changes
Jan 13, 2022
| style={{ display: "none" }} | ||
| ref={folderUpload} | ||
| /> | ||
| <> |
There was a problem hiding this comment.
Please use <Fragment> for consistency
There was a problem hiding this comment.
I see most examples on react using this shorthand, we should start adopting it
There was a problem hiding this comment.
Then we would need to change across all the code. I think Fragment is better because is more clear what this is referring to.
bexsoft
requested changes
Jan 13, 2022
| style={{ display: "none" }} | ||
| ref={folderUpload} | ||
| /> | ||
| <> |
There was a problem hiding this comment.
Then we would need to change across all the code. I think Fragment is better because is more clear what this is referring to.
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
bexsoft
approved these changes
Jan 13, 2022
| style={{ display: "none" }} | ||
| ref={folderUpload} | ||
| /> | ||
| <Fragment> |
jinapurapu
approved these changes
Jan 14, 2022
cniackz
approved these changes
Jan 14, 2022
adfost
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1390
Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com