Temporarily fix permission tests failing due to minio-js version bump #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaankabalak
requested review from
harshavardhana,
pjuarezd,
reivaj05,
cesnietor,
dvaldivia and
bexsoft
harshavardhana
approved these changes
Apr 30, 2024
Permission tests were failing due to function signature changes introduced with the latest minio-js release. This is a temporary measure until a Console PR to update test files is sent.
pjuarezd
approved these changes
Apr 30, 2024
kaankabalak
force-pushed
the
fix-minio-js-ver
branch
from
124dad5
to
6f9b246
Compare
|
Integration test failure seems to be unrelated with this PR, the Permission tests pass as opposed to what we have in #3319 with the latest minio-js version |
bexsoft
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix permission tests failing due to minio-js version bump
Permission tests were failing due to function signature changes
introduced with the latest minio-js release. This is a temporary
measure until a Console PR to update test files is sent.