Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing correct httpClient, do not use DefaultClients #3319

Merged
merged 1 commit into from
May 1, 2024

Conversation

harshavardhana
Copy link
Member

most of our deployments use custom certificates, using DefaultClient
makes it virtually impossible to make the share URL feature work.

This PR fixes this behavior during implementation.

Bonus: Reuse transports inside the console; will add more changes to
take custom transport inputs in subsequent PR.

@harshavardhana
Copy link
Member Author

15s
5s
Run npx testcafe "chrome:headless" web-app/tests/permissions-2/ -q --skip-js-errors -c 3
  npx testcafe "chrome:headless" web-app/tests/permissions-2/ -q --skip-js-errors -c 3
  shell: /usr/bin/bash -e {0}
ERROR Cannot prepare tests due to the following error:

Error: TypeScript compilation failed.
/home/runner/work/console/console/web-app/tests/utils/functions.ts (37, 5[1](https://github.com/minio/console/actions/runs/8899619047/job/24439524419?pr=3319#step:9:1)): Expected 1-3 arguments, but got 4.
/home/runner/work/console/console/web-app/tests/utils/functions.ts (66, 68): Expected 3-4 arguments, but got 5.

Can you guide me on this failure @kaankabalak ?

@kaankabalak
Copy link
Contributor

15s
5s
Run npx testcafe "chrome:headless" web-app/tests/permissions-2/ -q --skip-js-errors -c 3
  npx testcafe "chrome:headless" web-app/tests/permissions-2/ -q --skip-js-errors -c 3
  shell: /usr/bin/bash -e {0}
ERROR Cannot prepare tests due to the following error:

Error: TypeScript compilation failed.
/home/runner/work/console/console/web-app/tests/utils/functions.ts (37, 5[1](https://github.com/minio/console/actions/runs/8899619047/job/24439524419?pr=3319#step:9:1)): Expected 1-3 arguments, but got 4.
/home/runner/work/console/console/web-app/tests/utils/functions.ts (66, 68): Expected 3-4 arguments, but got 5.

Can you guide me on this failure @kaankabalak ?

Checking, my first impression is that this might've been caused by the new minio-js release, will keep you updated 👍

@kaankabalak
Copy link
Contributor

kaankabalak commented Apr 30, 2024

@harshavardhana, the tests seem to be failing as some of the function definitions have changed with the new minio-js release. Will send in a PR to resolve TypeScript compilation failed error 👍

For now, as a stopgap measure, we can replace yarn add minio in the .github/workflows/jobs.yaml file with yarn add minio@7.1.3 to fix these failures.

@harshavardhana
Copy link
Member Author

@harshavardhana, the tests seem to be failing as some of the function definitions have changed with the new minio-js release. Will send in a PR to resolve TypeScript compilation failed error 👍

For now, as a stopgap measure, we can replace yarn add minio in the .github/workflows/jobs.yaml file with yarn add minio@7.1.3 to fix these failures.

thanks @kaankabalak updated the PR with yarn add minio@7.1.3

most of our deployments use custom certificates, using DefaultClient
makes it virtually impossible to make share URL feature work.

this PR fixes this behavior in the implementation.

Bonus: re-use transports inside console, will add more changes to
take custom transport inputs in subsequent PR.
@harshavardhana
Copy link
Member Author

This PR adds a way for MinIO server to pass the right HTTP transport this allows for full removal of MINIO_SERVER_URL

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants