-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: passing correct httpClient, do not use DefaultClients #3319
Conversation
2f94947
to
bb7546b
Compare
Can you guide me on this failure @kaankabalak ? |
Checking, my first impression is that this might've been caused by the new minio-js release, will keep you updated 👍 |
@harshavardhana, the tests seem to be failing as some of the function definitions have changed with the new minio-js release. Will send in a PR to resolve TypeScript compilation failed error 👍 For now, as a stopgap measure, we can replace |
thanks @kaankabalak updated the PR with |
42c3abf
to
44aff79
Compare
88c0476
to
71786c2
Compare
most of our deployments use custom certificates, using DefaultClient makes it virtually impossible to make share URL feature work. this PR fixes this behavior in the implementation. Bonus: re-use transports inside console, will add more changes to take custom transport inputs in subsequent PR.
This PR adds a way for MinIO server to pass the right HTTP transport this allows for full removal of MINIO_SERVER_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
most of our deployments use custom certificates, using DefaultClient
makes it virtually impossible to make the share URL feature work.
This PR fixes this behavior during implementation.
Bonus: Reuse transports inside the console; will add more changes to
take custom transport inputs in subsequent PR.