Remove sts_expiry, username_format; add srv_record_name #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravindk89
approved these changes
Aug 10, 2023
|
So this https://jira.mongodb.org/browse/SERVER-32948 was from a while back, and I vaguely recall looking at the docs for it when I was at Mongo. But the technical discussions might assist in terms of understanding what DNS SRV lookup of LDAP servers does, and then how we are using a similar functionality. |
poornas
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove long-gone LDAP settings and add docs for a recent one.
Gone:
sts_expiry,MINIO_IDENTITY_LDAP_STS_EXPIRYusername_format,MINIO_IDENTITY_LDAP_USERNAME_FORMATRelated code change: minio/minio#13165
Recent:
srv_record_namefor lookup via DNS SVR recordsAdded in minio/minio#16201 RELEASE.2022-12-12T19-27-27Z
Staged:
http://192.241.195.202:9000/staging/DOCS-919-2-svc-record/linux/html/reference/minio-server/minio-server.html#envvar.MINIO_IDENTITY_LDAP_SRV_RECORD_NAME
http://192.241.195.202:9000/staging/DOCS-919-2-svc-record/linux/html/reference/minio-mc-admin/mc-admin-config.html#mc-conf.identity_ldap.srv_record_name