-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LDAP DNS SRV record lookup support #16201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatello
requested review from
vadmeste,
krisis,
harshavardhana and
kannappanr
December 10, 2022 20:01
klauspost
reviewed
Dec 12, 2022
donatello
force-pushed
the
ldap-srv
branch
2 times, most recently
from
December 12, 2022 17:29
0539efb
to
8bc2e04
Compare
krisis
approved these changes
Dec 12, 2022
harshavardhana
requested changes
Dec 12, 2022
The main change is in the minio/pkg lib, this change updates docs and adds configuration option.
Mint Automation
16201-7765bee/mint-pools.sh.log:
Deleting image on docker hub |
harshavardhana
approved these changes
Dec 12, 2022
feorlen
added a commit
to minio/docs
that referenced
this pull request
Aug 11, 2023
Remove long-gone LDAP settings and add docs for a recent one. Gone: - `sts_expiry`, `MINIO_IDENTITY_LDAP_STS_EXPIRY` - `username_format`, `MINIO_IDENTITY_LDAP_USERNAME_FORMAT` - Username-Bind mode Related code change: minio/minio#13165 Recent: - `srv_record_name` for lookup via DNS SVR records Added in minio/minio#16201 RELEASE.2022-12-12T19-27-27Z Staged: http://192.241.195.202:9000/staging/DOCS-919-2-svc-record/linux/html/reference/minio-server/minio-server.html#envvar.MINIO_IDENTITY_LDAP_SRV_RECORD_NAME http://192.241.195.202:9000/staging/DOCS-919-2-svc-record/linux/html/reference/minio-mc-admin/mc-admin-config.html#mc-conf.identity_ldap.srv_record_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main change is in the minio/pkg lib, this change updates docs and adds configuration option.
Needs minio/pkg#52
Motivation and Context
DNS SRV records are used for LDAP high-availability - https://ldap.com/dns-srv-records-for-ldap/
How to test this PR?
Test setup would need a configured DNS SRV record - this change is not end to end tested. However, it is possible to ensure that DNS SRV querying is working by picking a public DNS SRV record (e.g. _ldap._tcp.google.com ) - obviously cannot login with that, you can get a credentials invalid error.
Types of changes
Checklist:
commit-id
orPR #
here)