Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql events notification #294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

romanchechyotkin
Copy link

added functionality for creating postgresql events notification

@romanchechyotkin
Copy link
Author

romanchechyotkin commented Jul 29, 2024

this was created using examples/set_postgresql_notification.go file
image

@romanchechyotkin
Copy link
Author

then i want to add functionality for connecting configuared event notification to bucket in minio-go
image

@romanchechyotkin
Copy link
Author

i suppose there is need to write kind of this functions for oher integrations like MySQl, Redis, Kafka and etc

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what purpose does this API solve that you can't do via SetConfigKV ?

@romanchechyotkin
Copy link
Author

romanchechyotkin commented Jul 30, 2024

using options struct instead of the raw string
i guess this way more self-explanatory then using set config and provide the raw string
under the hood, this function calls SetConfigKV but builds config string using provided parameters from struct

@klauspost
Copy link
Contributor

Pro: Convenient
Cons: Seems a bit strange to offer this as a single config to abstract.

Undecided.

@romanchechyotkin
Copy link
Author

Yea, i am going to implement this functionality for all supported integratioins, theres is reused config values

        // Staging directory for undelivered messages e.g. '/home/events'
	QueueDir string

	// Maximum limit for undelivered messages, defaults to '10000'
	QueueLimit uint

	// Specify a comment to associate with the Postgresql configuration
	Comment string

The question is if it would be accepted as test for postgresql, if yes i continue to implement this functionality

@harshavardhana
Copy link
Member

It is not implemented purposely, so we don't have to bind by some structured contract. If we merge and publish this, we must maintain it for eternity. the KV API is kept fluid as the MinIO server changes it also changes automatically without making any new "madmin-go" releases.

If you want, you can keep a fork for your work that wraps on top of this SDK. While convenient there, this PR is a hidden burden on why we didn't do it ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants