-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postgresql events notification #294
base: main
Are you sure you want to change the base?
postgresql events notification #294
Conversation
then i want to add functionality for connecting configuared event notification to bucket in minio-go |
i suppose there is need to write kind of this functions for oher integrations like MySQl, Redis, Kafka and etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what purpose does this API solve that you can't do via SetConfigKV
?
using options struct instead of the raw string |
Pro: Convenient Undecided. |
Yea, i am going to implement this functionality for all supported integratioins, theres is reused config values // Staging directory for undelivered messages e.g. '/home/events'
QueueDir string
// Maximum limit for undelivered messages, defaults to '10000'
QueueLimit uint
// Specify a comment to associate with the Postgresql configuration
Comment string The question is if it would be accepted as test for postgresql, if yes i continue to implement this functionality |
It is not implemented purposely, so we don't have to bind by some structured contract. If we merge and publish this, we must maintain it for eternity. the KV API is kept fluid as the MinIO server changes it also changes automatically without making any new "madmin-go" releases. If you want, you can keep a fork for your work that wraps on top of this SDK. While convenient there, this PR is a hidden burden on why we didn't do it ourselves. |
added functionality for creating postgresql events notification