Onboard Diagnostics

[wlan0]

This is an accompanying PR to minio/minio#9024. This should be merged only after the server side is merged

[kannappanr]

@wlan0 Unable to compile the PR

$ make install
Checking dependencies
Building mc binary to './mc'
go: downloading github.com/mattn/go-isatty v0.0.8
go: downloading github.com/mattn/go-colorable v0.1.4
go: extracting github.com/mattn/go-colorable v0.1.4
go: extracting github.com/mattn/go-isatty v0.0.8
go: finding github.com/mattn/go-isatty v0.0.8
# github.com/minio/mc/cmd
cmd/admin-config-export.go:88:28: not enough arguments in call to client.GetConfig
	have ()
	want (context.Context)
cmd/admin-config-get.go:99:31: not enough arguments in call to client.HelpConfigKV
	have (string, string, bool)
	want (context.Context, string, string, bool)
cmd/admin-config-get.go:112:30: not enough arguments in call to client.GetConfigKV
	have (string)
	want (context.Context, string)
cmd/admin-config-history.go:130:53: not enough arguments in call to client.ClearConfigHistoryKV
	have (string)
	want (context.Context, string)
cmd/admin-config-history.go:137:44: not enough arguments in call to client.ListConfigHistoryKV
	have (int)
	want (context.Context, int)
cmd/admin-config-import.go:99:41: not enough arguments in call to client.SetConfig
	have (*os.File)
	want (context.Context, io.Reader)
cmd/admin-config-reset.go:110:31: not enough arguments in call to client.HelpConfigKV
	have (string, string, bool)
	want (context.Context, string, string, bool)
cmd/admin-config-reset.go:124:43: not enough arguments in call to client.DelConfigKV
	have (string)
	want (context.Context, string)
cmd/admin-config-restore.go:97:54: not enough arguments in call to client.RestoreConfigHistoryKV
	have (string)
	want (context.Context, string)
cmd/admin-config-set.go:108:31: not enough arguments in call to client.HelpConfigKV
	have (string, string, bool)
	want (context.Context, string, string, bool)
cmd/admin-config-set.go:108:31: too many errors
Makefile:75: recipe for target 'build' failed
make: *** [build] Error 2

[wlan0]

@kannappanr you will only be able to do it after the minio side of it gets merged

[kannappanr]

which package should I use madmin?

[vadmeste]

@kannappanr you will only be able to do it after the minio side of it gets merged

@wlan0, this should be already done, you only have to rebase.

[poornas]

--json option is not printing obd info in json format. Might want to remove this from the globalFlags if --json format is not going to be supported.

[kannappanr]

PTAL at build failure

[wlan0]

@kannappanr @poornas @klauspost PTAL -I've addressed your comments

[poornas]

@wlan0 , --json mode can just print json on the screen instead of the progress display and saving to .gz file. Can that be changed in this PR?

[wlan0]

@poornas I fixed it already - it doesnt print progress and does not save to a file

[poornas]

@poornas I fixed it already - it doesnt print progress and does not save to a file

thanks @wlan0, I see it now.

[poornas]

LGTM

[kannappanr]

In the json mode, you need to have a status field

$ mc ls play/test --json
{
 "status": "success",
 "type": "file",
 "lastModified": "2020-03-31T00:27:39.294-07:00",
 "size": 26,
 "key": "issue",
 "etag": "b954418e6a50d4d4cb8f02776d867550"
}
{
 "status": "success",
 "type": "file",
 "lastModified": "2020-03-31T00:56:46.882-07:00",
 "size": 26,
 "key": "issue1",
 "etag": "b954418e6a50d4d4cb8f02776d867550"
}

There is always a status field. In the case of error , the status will be error and there will also be an error field.

In the case of error, there will be an error field

[kannappanr]

The command seems to hang in the case where the server is old or is a gateway

[wlan0]

@kannappanr There is a Status and a Error field. I had set both to omitempty earlier, and wasn't setting either Status or Error. Its fixed now.

Now it errors out in case of gateway mode/old server

[wlan0]

@harshavardhana addressed your comments as well

[kannappanr]

LGTM