Updated API.md intro to reflect current API usage #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While having a total brainfart moment (I apparently forgot that scrolling exists), I was going insane trying to figure out why the Minio client was not able to communicate over SSL. I was madly following the debugger and not understanding why the client still had http even though it *clearly* used .WithSSL() An hour of stepping through the source code (obviously! Dump that nuget package and just link against the source!), and I eventually found the [Obsolete] tag on the constructor used in this example. I, of course, did a Git blame to find out how long it had been there. 2 years. About time someone fixes this. It's a copy paste of the example just a little bit further down. I also removed the .WithSSL() calls on the "obsolete" constructor. That won't work. (this.HTTPClient is never created unless MinioClient() constructor is run, and just silently fails, and doesn't use SSL) Just to save someone else from pulling their hair out too.
harshavardhana
approved these changes
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While having a total brainfart moment (I apparently forgot that scrolling exists), I was going insane trying to figure out why the Minio client was not able to communicate over SSL. I was madly following the debugger and not understanding why the client still had http even though it clearly used .WithSSL()
An hour of stepping through the source code (obviously! Dump that nuget package and just link against the source!), and I eventually found the [Obsolete] tag on the constructor used in this example.
I, of course, did a Git blame to find out how long it had been there. 2 years.
About time someone fixes this. It's a copy paste of the example just a little bit further down.
I also removed the .WithSSL() calls on the "obsolete" constructor. That won't work. (this.HTTPClient is never created unless MinioClient() constructor is run, and just silently fails, and doesn't use SSL)
Just to save someone else from pulling their hair out too.