-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mint dotnet failure TaskCanceledException #663
Conversation
I mistakenly picked up changes from others in files:
|
77a8625
to
d34f526
Compare
There is an incorrect build warning message and the fix for it clashes with
|
is this PR ready @ebozduman ? |
Tried to cleanup the So, it is ready for review now. |
f9e7b5b
to
d371d4b
Compare
@harshavardhana |
Please rebase with master |
d371d4b
to
36be4d3
Compare
Some old code made into this PR. I guess I made some mistake during rebase. |
I think it is ready 'now'. |
Fix for sporadic
TaskCanceledException
during Mint test runs.The added
ConfigureAwait
method is for telling the Task to resume itself on any thread that is available instead of waiting for the thread that originally created it. This will speed up the responses and avoid deadlocks and timeouts.Deadlocks/Timeouts may happen if another long-running process currently has taken over the thread, async/await was waiting for. If that happens, the awaiting task will be stuck waiting for the thread to complete the other long running task/process, which may end up causing timeouts.
This fix still needs to be tested within Mint environment.