Mint dotnet failure TaskCanceledException #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mistakenly picked up changes from others in files:
|
ebozduman
force-pushed
the
mint-dotnet-failure
branch
from
77a8625
to
d34f526
Compare
|
There is an incorrect build warning message and the fix for it clashes with
|
|
is this PR ready @ebozduman ? |
|
Tried to cleanup the So, it is ready for review now. |
harshavardhana
requested changes
Jul 20, 2022
ebozduman
force-pushed
the
mint-dotnet-failure
branch
from
f9e7b5b
to
d371d4b
Compare
|
@harshavardhana |
|
Please rebase with master |
ebozduman
force-pushed
the
mint-dotnet-failure
branch
from
d371d4b
to
36be4d3
Compare
|
Some old code made into this PR. I guess I made some mistake during rebase. |
|
I think it is ready 'now'. |
harshavardhana
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for sporadic
TaskCanceledExceptionduring Mint test runs.The added
ConfigureAwaitmethod is for telling the Task to resume itself on any thread that is available instead of waiting for the thread that originally created it. This will speed up the responses and avoid deadlocks and timeouts.Deadlocks/Timeouts may happen if another long-running process currently has taken over the thread, async/await was waiting for. If that happens, the awaiting task will be stuck waiting for the thread to complete the other long running task/process, which may end up causing timeouts.
This fix still needs to be tested within Mint environment.