Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PutObjectAsync with Snowball header must not use multipart #786

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

emrocha
Copy link
Contributor

@emrocha emrocha commented May 19, 2023

PutObjectAsync must not use multipart if has header "X-Amz-Meta-Snowball-Auto-Extract=true".
See minio/minio#17033

PutObjectAsync must not use multipart if has header "X-Amz-Meta-Snowball-Auto-Extract=true"
See minio/minio#17033
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But we should keep in mind that this is not enough to support Snowball.

@emrocha
Copy link
Contributor Author

emrocha commented Jun 15, 2023

Yes. I could write a function similar to upload_snowball_objects from the Python client.

Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (#797 addresses the missing snowball support)

@ebozduman ebozduman merged commit db8e206 into minio:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants