fix: add missing return in optimalPartInfo #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit test |
|
@poornas Please check the Appveyor build failure |
- when client has not configured part size, use optimal part size determined by SDK. Otherwise honor the client specified part size fixes: minio#1099
fixed @kannappanr |
harshavardhana
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing return in optimalPartInfo as reported in fixes: #1099
In addition, found that the optimalPartInfo calculation has regressed from using maximal partsize when client did not configure a part size. Essentially, though the default SDK minimum part size is 64Mib, sdk should use a higher part size if possible that fits other multipart constraints for optimal chunking.