-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add opts for replication deletes #1379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested changes
Aug 31, 2020
harshavardhana
requested changes
Sep 9, 2020
harshavardhana
approved these changes
Sep 9, 2020
6 tasks
harshavardhana
requested changes
Sep 11, 2020
Enhancing StatObjectOptions, RemoveObjectOptions for propagating replication deletes. Add xml field to allow versioned deletes replication as a MinIO extension. This PR also enhances replication pkg to toggle DeleteMarkerReplication and DeleteReplication statuses, intended for `mc replicate set/add` commands
harshavardhana
approved these changes
Sep 11, 2020
kannappanr
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing StatObjectOptions, RemoveObjectOptions
for propagating replication deletes.
This PR also enhances replication pkg to
toggle DeleteMarker replication flag, intended
for
mc replicate set/add
commands