fix MinioAdminClient.listCannedPolicies() to return proper string values #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Jan 21, 2022
harshavardhana
previously approved these changes
Jan 24, 2022
harshavardhana
previously approved these changes
Jan 24, 2022
harshavardhana
approved these changes
Jan 25, 2022
balamurugana
changed the title
balamurugana
approved these changes
Jan 26, 2022
|
Any chance we can get a release for this @balamurugana / @harshavardhana ? |
Soon @Sam-Kramer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the returned map when listing all canned policies will return <String, LinkedHashMap> due to the policy (value) being a json blob. There's really no nice way to force jackson to treat it as raw json, thus my suggestion is to just treat it as a JsonNode, which then the user can either convert to a String, or if they've a pojo if they have it.
First commit shows how the unit test fix exposes the failure, and the second commit contains the actual fix.