Abort failed multipart uploads on RuntimeException #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file > 5MB is being uploaded to a bucket, this client will initiate
a multipart upload. However, if in the course of uploading that file a
RuntimeException occurs, this library will not abort the multipart
upload. This is especially possible when streaming data across a
network connection into a bucket. This was introduced in #741 when
resuming failed multipart uploads was removed.
Reproduction steps:
valid values
with
s3cmd multipart s3://bucket-name
(or another tool)Subsequent runs of the script create new multipart uploads in the
bucket.
I specifically noticed this bug when using this library against Ceph, if
that's relevant.