Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix {copy,compose}Object to handle single source appropriately. #995

Conversation

balamurugana
Copy link
Member

  • When size of source of copyObject() is greater than 5GiB, use composeObject().
  • When single source of composeObject() makes single part with no offset/length,
    use copyObject().

@balamurugana balamurugana force-pushed the fix-copy-compose-Object-to-handle-single-source-appropriately branch 3 times, most recently from f58b492 to abe9967 Compare June 29, 2020 16:49
* When size of source of copyObject() is greater than 5GiB, use composeObject().
* When single source of composeObject() makes single part with no offset/length,
  use copyObject().
@balamurugana balamurugana force-pushed the fix-copy-compose-Object-to-handle-single-source-appropriately branch from abe9967 to ae21625 Compare July 2, 2020 05:00
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 9f429dd into minio:master Jul 3, 2020
@balamurugana balamurugana deleted the fix-copy-compose-Object-to-handle-single-source-appropriately branch July 8, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants