Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Content type by default can also be binary/octet-stream #746

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

kannappanr
Copy link
Collaborator

If copy object call is made with the option of replacing metadata,
and content type is not set, then the default content type can be either
binary/octet-stream or application/octet-stream.

Test should treat both as same.

Fixes minio/minio#7238

@sinhaashish
Copy link
Contributor

@kannappanr Can you check the travis failure .

@kannappanr
Copy link
Collaborator Author

@kannappanr Can you check the travis failure .

fixed

If copy object call is made with the option of replacing metadata,
and content type is not set, then the default content type can be either
binary/octet-stream or application/octet-stream.

Test should treat both as same.

Fixes minio/minio#7238
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Collaborator Author

ping @harshavardhana

@kannappanr kannappanr merged commit 3491bf7 into minio:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants