Avoid passing the client to the assume role provider #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
fix-assumerole-design
branch
from
408ae95
to
a36778d
Compare
harshavardhana
previously approved these changes
May 3, 2020
balamurugana
reviewed
May 4, 2020
Praveenrajmani
force-pushed
the
fix-assumerole-design
branch
7 times, most recently
from
f8309f1
to
c2c34cc
Compare
|
Addressed the comments @balamurugana. PTAL. |
Praveenrajmani
force-pushed
the
fix-assumerole-design
branch
8 times, most recently
from
c7cc15f
to
316a18e
Compare
Instead, have a callback with arguments (Merely a design fix)
Praveenrajmani
force-pushed
the
fix-assumerole-design
branch
from
316a18e
to
007d65f
Compare
harshavardhana
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, have a callback with arguments (Merely a design fix)